Apply authorisation changes to actors controller #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parndt could you add the missing tests for deleting actors similar to how you it was done for measures? https://github.com/dumparkltd/advocacy-tracker-server/pull/71/files#diff-bcab87d0b7330bc8be55be2eab9f679bcab9a1b9c949d502b69e2b37a1ba49b7 |
@parndt there also appear some other tests failing, could you have a look? thanks |
|
@tmfrnz sure thing! |
parndt
changed the title
parndt
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to extend the deletion functionality from #71 to actors.
The specs were not happy to let an 'analyst' update an actor when
it was draft, so this is now tested with a
:not_draftactor.