Skip to content

Commit

Permalink
chore(test): more gulp todos
Browse files Browse the repository at this point in the history
  • Loading branch information
duncdrum committed Jan 13, 2021
1 parent 4911e6a commit 1117e75
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,8 @@ module.exports = class extends Generator {
this.spawnCommandSync('git', ['add', '--all'])
this.spawnCommandSync('git', ['commit', '-q', '-m', '\'initial scaffolding by Yeoman\''])
}
this.spawnCommandSync('ant', '-q')
// TODO: [gulp] line-o make conditional on selected build tool
this.spawnCommandSync('ant', '-q')

// TODO: [gulp] line-o conditional gulp watch
// if (this.props.apptype[0] === 'polymer') {
Expand Down
3 changes: 3 additions & 0 deletions test/generated-pkg/app-empty.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const fs = require('fs-extra')

describe('empty package', function () {
this.timeout(15000)
// TODO: #563 [gulp] line-o let's make this the test application for pure gulp build
// we should also add a second app-lib-gulp bringing some of the old polymer file checks
// over and testing the proper gulpfile contents for libs vs apps
before(async function () {
await helpers.run(path.join(__dirname, '../../generators/app'))
.withPrompts({
Expand Down

0 comments on commit 1117e75

Please sign in to comment.