-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: adding Huff
language support to playground code editor.
#150
Feature: adding Huff
language support to playground code editor.
#150
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR ;-)
I must admit I am discovering Huff with this PR, and I would love to know how you are planning to use this new feature with evm.codes.
I will also let @malexw to evaluate it technically.
@@ -27,6 +27,7 @@ | |||
"gray-matter": "^4.0.3", | |||
"highlight.js": "^11.3.1", | |||
"highlightjs-solidity": "^2.0.1", | |||
"huffc": "Saw-mon-and-Natalie/huffc.git#fileless-parser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything, why not point to the original repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original repo only compiles files and not the content as strings. It also misses declaration files for typescript.
Once those has been added/modified in the original repo, we can change this to huffc
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a PR for huffc
to include the required changes:
feat: Allow parsing/compiling of content only data ...
Once that PR is reviewed and merged, we can update this dependency
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great thanks :-)
@peroket , Huff like other low-level languages ( Adding support for this language to evm.codes would be a great resource for teaching how to use the language and also to onboard new developers. |
@Saw-mon-and-Natalie : any news on getting huff-language/huffc#40 in ? (we would like to merge this change but prefer to do so after this is in and the dependency is changed) |
@dorlevi amazing. I'll ping the team Huff. |
Sure thing, hope you understand why we want to wait for that to get resolved, and thanks again for contributing. |
@Saw-mon-and-Natalie Any news on merging the huf change? |
Hi @dorlevi 👋🏽, My PR was never reviewed on the |
Thank you for your anwser. Are you going to update your PR with the new one? We can't add a dependency if the repo is not going to be maintained unfortunately. |
I've actually been working on wasm bindings for the huff compiler. Once we've got them working I'd be happy to submit a PR if you don't mind @Saw-mon-and-Natalie? |
@ncitron LFG |
@Saw-mon-and-Natalie and @ncitron, I'm just doing some housekeeping and wanted to check in on this. |
Since there was no update on this in a long while, I'm closing the PR, but we would be happy to get that change if you have some time :-) |
This PR adds support for Huff language (a low-level EVM language).
yarn lint
yarn dev
functional