Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Iter and IntoIter for Polynomial #759

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Implement Iter and IntoIter for Polynomial #759

merged 2 commits into from
Aug 17, 2023

Conversation

erikareale
Copy link
Contributor

Related issue(s)

Related to #174.

Description

Changes

  • make the Vec inside of the Polynomial struct private
  • implement IntoIterator for Polynomial
  • implement iter() for Polynomial
  • propagate the effects of previous changes by removing direct access to the wrapped Vec

@ureeves ureeves marked this pull request as ready for review August 17, 2023 17:15
ureeves
ureeves approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the contribution! The coverage is failing but that's on our end. No big deal.

@ureeves ureeves merged commit 5eabd2c into dusk-network:master Aug 17, 2023
@ureeves ureeves mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikareale @ureeves