rusk-wallet: Fix stake lower limit when performing topup #3431
+3,154
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
requested changes
Jan 27, 2025
herr-seppia
requested changes
Jan 27, 2025
| let owner = match wallet.find_stake_owner_account(stake_pk).await { | ||
| Ok(account) => account, | ||
| Ok(account) => { |
There was a problem hiding this comment.
Having a stake owner is not enough to know if there is a stake amount
Indeed, if the user has no stake but still has rewards to withdraw, this match will incorrectly results in "has_stake=true"
There was a problem hiding this comment.
@herr-seppia I fixed this check please check again
Daksh14
force-pushed
the
rusk-wallet-topup-fix
branch
2 times, most recently
from
a9cccd7 to
611a4aa
Compare
herr-seppia
requested changes
Jan 30, 2025
rusk-wallet/Cargo.lock
Outdated
There was a problem hiding this comment.
rusk-wallet uses the parent Cargo.lock, please remove this file
Daksh14
force-pushed
the
rusk-wallet-topup-fix
branch
2 times, most recently
from
3ff836d to
a46c867
Compare
Daksh14
force-pushed
the
rusk-wallet-topup-fix
branch
from
a0abca5 to
612b643
Compare
herr-seppia
requested changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3394