Remove optional owner #21
Conversation
| @@ -168,8 +156,6 @@ impl TokenState { | |||
| ), | |||
| } | |||
|
|
|||
| self.owner = None; | |||
There was a problem hiding this comment.
From what I see, this function does not renounce the owner anymore. We can also set it to "Account::Contract(ContractId::from_bytes([0; CONTRACT_ID_BYTES]))," here, or?
There was a problem hiding this comment.
Indeed I'm not sure we should have that function at all, but maybe I'm missing something
What happens when there is no owner anymore?
There was a problem hiding this comment.
Indeed I'm not sure we should have that function at all, but maybe I'm missing something What happens when there is no owner anymore?
Then there is no owner and no one can be an owner. This is only useful in certain cases (where only a temporary owner is needed) and not everyone has a use for this feature.
I added this feature to be more in line with the Ownable contract interface on ETH. We can always remove it in the future, but the current implementation here does not work.
There was a problem hiding this comment.
Gotcha, then I'll reset the owner to default value as you suggested
No description provided.