Fix tests #1486
Merged
Fix tests #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
garak
requested changes
Jan 20, 2025
| @@ -157,9 +152,9 @@ public static function pathProvider(): array | |||
| return [ | |||
| // dir, path, relative | |||
| [null, 'file.txt', true], | |||
| [null, '/absolute/file.txt', false], | |||
| [null, 'file.txt', false], | |||
There was a problem hiding this comment.
any reason for changing these values?
There was a problem hiding this comment.
@garak these tests were actually skipped, no way for them to work because absolute path is not handled by flysystem storage anymore (as FlysystemOperator does not provide any ways to get this):
VichUploaderBundle/src/Storage/FlysystemStorage.php
Lines 76 to 79 in 79fd69a
garak
approved these changes
Jan 23, 2025
|
The tests are currently failing because
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix some tests that were skipped because of bad "@requires" annotation