Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF to PNG with PDFium #408

Merged
merged 20 commits into from
Jan 2, 2025
Merged

PDF to PNG with PDFium #408

merged 20 commits into from
Jan 2, 2025

Conversation

laura-borghesi-lum00n
Copy link
Contributor

@laura-borghesi-lum00n laura-borghesi-lum00n commented Dec 12, 2024

This PR replaces the existing pdf.js dependency with PDFium to handle PDF-to-PNG conversion. The switch to PDFium is intended to improve performance and adaptability to electron environment in the conversion process, managing the process in the browser and not in node.js.

However, the PDFium package has a known issue in its package.json configuration, which requires a fix to ensure proper functionality. To address this, a post-installation step has been added using patch-package. This step automatically applies the necessary patch after dependencies are installed, preventing runtime errors caused by the default issue in the PDFium package.

@laura-borghesi-lum00n laura-borghesi-lum00n marked this pull request as ready for review December 13, 2024 08:20
@daron1337 daron1337 merged commit 200dc47 into master Jan 2, 2025
1 check passed
@daron1337 daron1337 deleted the TestPdf branch January 2, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants