Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: tidy README.md #280 #286

Merged
merged 11 commits into from
Jun 16, 2024
Merged

PR: tidy README.md #280 #286

merged 11 commits into from
Jun 16, 2024
+185 −76

Conversation

nelsonic
Copy link
Member

Busy tidying the README.md ahead of fixing #280

@nelsonic
tidy README.md #280
Loading
Loading status checks…
63850b5
@nelsonic nelsonic self-assigned this Jun 14, 2024
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 14, 2024 21:59 — with GitHub Actions Inactive
@nelsonic nelsonic added in-progress An issue or pull request that is being worked on by the assigned person technical A technical issue that requires understanding of the code, infrastructure or dependencies chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written documentation Improvements or additions to documentation labels Jun 14, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8bad499) to head (53e402f).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #286   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           87        87           
=========================================
  Hits            87        87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nelsonic added 2 commits June 15, 2024 13:43
@nelsonic
create .env_sample to show example ...
04a99a4
@nelsonic
add apple touch icons to avoid noisy warnings/erros see: dwyl/who#172

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
ab5908d
@nelsonic nelsonic had a problem deploying to liveview-chat-example June 15, 2024 16:36 — with GitHub Actions Failure
@nelsonic
reword README.md intro #280
Loading
Loading status checks…
89e03dc
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 15, 2024 16:38 — with GitHub Actions Inactive
@nelsonic
remove depracated get_flash from tempate #280
Loading
Loading status checks…
099afe6
@nelsonic nelsonic had a problem deploying to liveview-chat-example June 16, 2024 18:43 — with GitHub Actions Failure
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2024 18:54 — with GitHub Actions Inactive
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2024 19:42 — with GitHub Actions Inactive
@nelsonic
use Elixir v 1.17 and OTP 27.0 in ci.yml #280
Loading
Loading status checks…
21375dd
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2024 19:43 — with GitHub Actions Inactive
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2024 20:20 — with GitHub Actions Inactive
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2024 20:26 — with GitHub Actions Inactive
@nelsonic nelsonic requested a review from asntc June 16, 2024 20:26
@nelsonic nelsonic assigned asntc and unassigned nelsonic Jun 16, 2024
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jun 16, 2024
@nelsonic
Copy link
Member Author

Working again on fly.io ✅
#280 (comment)

asntc
asntc approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@asntc asntc merged commit 3bf0caf into main Jun 16, 2024
3 checks passed
@asntc asntc deleted the fix-502-error-issue#280 branch June 16, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asntc asntc

Assignees

@asntc asntc

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nelsonic @asntc