Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Updating README and BUILD. #192

Merged
merged 4 commits into from
Oct 27, 2022
Merged

[PR] Updating README and BUILD. #192

merged 4 commits into from
Oct 27, 2022

Conversation

LuchoTurtle
Copy link
Member

fixes #190

As requested, here's the PR of the changes to README and possibly BUILD while running the MVP.

@LuchoTurtle LuchoTurtle added the chore a tedious but necessary task often paying technical debt label Oct 26, 2022
@LuchoTurtle LuchoTurtle self-assigned this Oct 26, 2022
@LuchoTurtle LuchoTurtle temporarily deployed to dwylauth October 26, 2022 11:43 Inactive
@LuchoTurtle LuchoTurtle temporarily deployed to dwylauth October 26, 2022 11:44 Inactive
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #192 (56a956d) into main (81b1d2f) will increase coverage by 1.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #192      +/-   ##
===========================================
+ Coverage   98.64%   100.00%   +1.35%     
===========================================
  Files          13        13              
  Lines         221       221              
===========================================
+ Hits          218       221       +3     
+ Misses          3         0       -3     
Impacted Files Coverage Δ
lib/app_web/live/app_live.ex 100.00% <0.00%> (+3.89%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle LuchoTurtle temporarily deployed to dwylauth October 26, 2022 19:15 Inactive
@LuchoTurtle
Copy link
Member Author

Just got through replicating the project and I fixed/clarified some aspects as I was reading, implementing, and testing.

Overall, it's a great read and very detailed, so not much was needed to change. But sometimes I was stumped because I didn't know where I should use some code snippets. It should be more clear now 😄

@LuchoTurtle LuchoTurtle requested a review from nelsonic October 26, 2022 19:18
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Oct 26, 2022
@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Oct 27, 2022
@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Oct 27, 2022
BUILDIT.md Outdated Show resolved Hide resolved
BUILDIT.md Show resolved Hide resolved
@nelsonic nelsonic temporarily deployed to dwylauth October 27, 2022 10:01 Inactive
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle Looks great! Thanks! :shipit:

@nelsonic nelsonic merged commit f5bd6f1 into main Oct 27, 2022
@nelsonic nelsonic deleted the readme-refactor branch October 27, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Run the MVP on localhost
2 participants