-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Updating README and BUILD. #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
===========================================
+ Coverage 98.64% 100.00% +1.35%
===========================================
Files 13 13
Lines 221 221
===========================================
+ Hits 218 221 +3
+ Misses 3 0 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Just got through replicating the project and I fixed/clarified some aspects as I was reading, implementing, and testing. Overall, it's a great read and very detailed, so not much was needed to change. But sometimes I was stumped because I didn't know where I should use some code snippets. It should be more clear now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuchoTurtle Looks great! Thanks!
fixes #190
As requested, here's the PR of the changes to README and possibly BUILD while running the MVP.