More FCM infra: wire up token registration, analytics, toasts, primer… #226
Conversation
...tegration/fcm/src/main/java/exchange/dydx/trading/integration/fcm/PushPermissionRequester.kt
Outdated
Show resolved
Hide resolved
| private val sharedPreferencesStore: SharedPreferencesStore, | ||
| ) : PushPermissionRequester { | ||
|
|
||
| var requestPermissionLauncher: ActivityResultLauncher<String>? = null |
There was a problem hiding this comment.
Where does this get initialized?
There was a problem hiding this comment.
in the set() for activity - this API is really awkward and requires an Activity
There was a problem hiding this comment.
happy to huddle on this to explain what's going on here.
basically you can't get an Activity injected via Hilt into a ViewModel, because of the component structure: https://dagger.dev/hilt/components.html
so we need to pass TradingActivity in onCreate/onDestroy to the PushPermissionRequester. when activity changes, we need to update requestPermissionLauncher.
this should almost never happen since we're an single-activity app, but handling it just in case.
There was a problem hiding this comment.
oh oops yeah i forgot to assign this in the setter
...n/fcm/src/main/java/exchange/dydx/trading/integration/fcm/PushPermissionRequesterProtocol.kt
Outdated
Show resolved
Hide resolved
v4/integration/fcm/src/main/java/exchange/dydx/trading/integration/fcm/ActivityDelegate.kt
Outdated
Show resolved
Hide resolved
… dialog.
i haven't had a chance to test this end to end yet.