Grant reward points on evaluation deletion #2358
Open
+151
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
commented
Dec 21, 2024
richardebeling
commented
Dec 21, 2024
richardebeling
commented
Dec 21, 2024
niklasmohrin
reviewed
Jan 6, 2025
richardebeling
force-pushed
the
grant-reward-points-on-evaluation-deletion
branch
from
dd444a3 to
fc8f88a
Compare
richardebeling
force-pushed
the
grant-reward-points-on-evaluation-deletion
branch
from
fc8f88a to
ebdb5f5
Compare
richardebeling
commented
Mar 3, 2025
| participants = list(instance.participants.all()) | ||
| instance.participants.clear() | ||
| for user in participants: | ||
| granting, __ = grant_reward_points_if_eligible(user, instance.course.semester) |
There was a problem hiding this comment.
note to self: TODO: Add tests that the reward points are actually granted (evaluation deletion, user profile edit)
richardebeling
force-pushed
the
grant-reward-points-on-evaluation-deletion
branch
from
ebdb5f5 to
7e0b5d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2279