Test mismatching testdata #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooooosef
force-pushed
the
testMismatchingTestdata
branch
5 times, most recently
from
148e064 to
fa8e80f
Compare
jooooosef
force-pushed
the
testMismatchingTestdata
branch
from
5112277 to
2a930ff
Compare
niklasmohrin
approved these changes
Feb 10, 2025
Kakadus
approved these changes
Feb 13, 2025
|
@jooooosef could you rebase this? |
When adding migrations and adding or modifying fields one might forget to change test_data.json. This test aims to check if that happend by making a new test_data.json and comparing it.
jooooosef
force-pushed
the
testMismatchingTestdata
branch
from
2a930ff to
6013686
Compare
niklasmohrin
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #2382 we added a field to some data in test_data.json after the migration that added this field was added because it was forgetten in the original pr.
To prevent that from happening in the future I added this test.