Collapsable box for participants in evaluation form #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the issue: "The number should update on field changes." Have a look at https://tom-select.js.org/examples/events/ for the events of the component. |
janno42
requested changes
Feb 10, 2025
evap/evaluation/templates/evaluation_form_general_questionnaires.html
Outdated
Show resolved
Hide resolved
evap/evaluation/templates/evaluation_form_general_questionnaires.html
Outdated
Show resolved
Hide resolved
evap/evaluation/templates/evaluation_form_general_questionnaires.html
Outdated
Show resolved
Hide resolved
evap/evaluation/templates/evaluation_form_general_questionnaires.html
Outdated
Show resolved
Hide resolved
niklasmohrin
requested changes
Feb 24, 2025
Comment on lines
+76
to
+86
| let participant_list = document.getElementById("id_participants").tomselect; | ||
| participant_list.on("item_add", function() { | ||
| count_participants(); | ||
| }); | ||
| participant_list.on("item_remove", function() { | ||
| count_participants(); | ||
| }); | ||
|
|
||
| function count_participants(){ | ||
| participant_counter = document.getElementById("participant_counter"); | ||
| participant_counter.innerHTML = participant_list.items.length; |
There was a problem hiding this comment.
I think we can remove some specifics from this: Let's make it so that the participant_counter does not need to have a id anymore and instead it has, say, data-track-tomselect-count="#id_participants".
Additionally, we should use innerText instead of innerHTML
Comment on lines
+24
to
+26
| <div class="collapse{% if not collapse_participants or evaluation.participants.count == 0 %} show{% endif %}" id="contributor-{{ contribution_result.contributor.id }}"> | ||
| <div class="card-body"> | ||
| {% include 'bootstrap_form_field_widget.html' with field=field %} |
There was a problem hiding this comment.
What is this about contributors here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements visual changes suggested by @janno42 in #2333
for non staff users the list is always shown by default. For staff users the list is collapsed by default except when there are no participants