improve array enumeration in megaclisas-status #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change this script would fail if a controller has non consecutive arrays because the script expects the array id to start at 0 and increment to the array count. With this change we retrieve a list of all arrays per controller and iterate through that way. I believe this situation occurs when an array is deleted, in our situation array 0 was removed leaving just 1 & 2 Fixes eLvErDe#26
|
Might be the same as issue #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change this script would fail if a controller has non
consecutive arrays because the script expects the array id to start at 0
and increment to the array count.
With this change we retrieve a list of all arrays per controller and
iterate through that way.
I believe this situation occurs when an array is deleted, in our
situation array 0 was removed leaving just 1 & 2
Fixes #26