-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[urlrewrite] Minor edits #906
Conversation
joewiz
commented
Mar 20, 2023
- the /tools root is no longer in eXist
- the sandbox tool is no longer in eXist; adapted to discuss eXide
- added a few essential details to the picture of URL processing and controller-config
- incorporate recent changes to roots in Improve controller-config inline comments exist#4807
- reorder $exist:* variables from most general to most specific components
- add descriptions of common uses of URL rewriting
8519916
to
8107ce1
Compare
(I rebased this PR after merging #903, but CI tests are still failing on this PR. The tests in README.md - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are a big step forward for new users to understand the URL rewriting.
Many thanks.
I found some typos and have some questions. These can all be addressed at a later point if you do not feel they are urgent.
@joewiz does this need a rebase, or have these changes already been incorporated ? |
… most other articles in documentation use 2-space indent
@duncdrum It needs a rebase. Coming... |
ccf9e0b
to
633fbe6
Compare
633fbe6
to
fba8c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements. @line-o comments are still unresolved. I added a few stylistic notes. We should be consistent in the use of $
when referring to Xquery variable names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.