Feature/retrieve sfids from polygon #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpn-geo6
reviewed
May 27, 2024
There was a problem hiding this comment.
- missing attributes description in docstring
For example: geometry (str) : the input geometry - missing type in signature (geometry, season_fields_ids )
There was a problem hiding this comment.
assert on the len of the result can be dangerous: the test could fail if a new sfd is created in the geometry.
len = 20 seems to fit with the default limit of the response api ( which has been removed with the $limit=none)
|
updated PR |
jpn-geo6
approved these changes
May 29, 2024
jpn-geo6
merged commit 340052d
into
feature/adding_sensors_seasonfield_id
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.