Fix Spotbugs

easybill · Oct 16, 2024 · 756b364 · 756b364
1 parent c78d51c
commit 756b364
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/main/java/io/github/easybill/Dtos/ValidationResult.java b/src/main/java/io/github/easybill/Dtos/ValidationResult.java
@@ -1,6 +1,7 @@
 package io.github.easybill.Dtos;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Collections;
 import java.util.List;
 import org.checkerframework.checker.nullness.qual.NonNull;
 
@@ -9,6 +10,11 @@ public record ValidationResult(
     @NonNull List<@NonNull ValidationResultField> errors,
     @NonNull List<@NonNull ValidationResultField> warnings
 ) {
+    public ValidationResult {
+        errors = Collections.unmodifiableList(errors);
+        warnings = Collections.unmodifiableList(warnings);
+    }
+
     @JsonProperty("is_valid")
     public boolean isValid() {
         return errors.isEmpty();

diff --git a/src/main/java/io/github/easybill/Dtos/ValidationResultField.java b/src/main/java/io/github/easybill/Dtos/ValidationResultField.java
@@ -3,6 +3,7 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.helger.schematron.svrl.jaxb.FailedAssert;
 import com.helger.schematron.svrl.jaxb.Text;
+import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
 import org.checkerframework.checker.nullness.qual.NonNull;
@@ -18,6 +19,10 @@ public record ValidationResultField(
     @JsonProperty("rule_severity") @NonNull Severity severity,
     @JsonProperty("rule_messages") @NonNull List<@NonNull String> messages
 ) {
+    public ValidationResultField {
+        messages = Collections.unmodifiableList(messages);
+    }
+
     public static ValidationResultField fromFailedAssert(
         @NonNull FailedAssert failedAssert
     ) {