Apply mutex lock guard around notification write after obtaining from…

… server.
ebarlas · Sep 4, 2024 · 97c8c41 · 97c8c41
1 parent d2af95b
commit 97c8c41
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/net/StagingArea.cpp b/src/net/StagingArea.cpp
@@ -22,6 +22,11 @@ void trippin::StagingArea::setTopScores(std::vector<Score> scores) {
     topSet = true;
 }
 
+void trippin::StagingArea::setNotification(std::string n) {
+    std::lock_guard<std::mutex> lock(mutex);
+    notification = std::move(n);
+}
+
 std::vector<trippin::Score> trippin::StagingArea::getTodayScores(int limit) const {
     std::lock_guard<std::mutex> lock(mutex);
     return combine(todayScores, addedScores, limit);
@@ -70,7 +75,7 @@ void trippin::StagingArea::run() {
     while (true) {
         auto n = transport.getNotification();
         if (!n.empty()) {
-            notification = n;
+            setNotification(n);
             SDL_Log("set notification in staging area");
         }
         auto top = transport.topScores();

diff --git a/src/net/StagingArea.h b/src/net/StagingArea.h
@@ -34,6 +34,7 @@ namespace trippin {
         void run();
         void setTodayScores(std::vector<Score> scores);
         void setTopScores(std::vector<Score> scores);
+        void setNotification(std::string notification);
     };
 }