Null bytes fix, updated to SR28 data #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving directory refs as SR26 because I'm lazy/seems lower risk for first pass attempt
Also, file paths in import.sql hardcoded, hardcode…. differently… for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You probably won't want to merge this in as is, but thought it was worth PRing back as it's got newer data, a bug fix, and helps point out one thing not documented, that import.sql has hardcoded paths to your personal machine... If I have time, maybe I'll come back and update this so the Makefile generates the import.sql file from a template or something? and/or update the path names so sr28 is reflected instead of the quick fix I did, but for you or anyone else looking at the data set, this may save some work. Thanks for the tool!