Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some processing of Spotify data to the backend #71

Open
Noam-Bendelac opened this issue Dec 29, 2020 · 0 comments
Open

Move some processing of Spotify data to the backend #71

Noam-Bendelac opened this issue Dec 29, 2020 · 0 comments
Labels
backend Backend functionality frontend Frontend functionality
Milestone

Comments

@Noam-Bendelac
Copy link
Collaborator

Noam-Bendelac commented Dec 29, 2020

I think it might be better to do things like turning ArtistObjectSimplified[] into a string of comma-separated artists, or getting the name and image url out of AlbumObjectSimplified in the backend instead of multiple places in the frontend. This will also help with mocking track data for the add state, like #70.

Things to possibly change:

All of these should be done for all applicable endpoints, like /api/playlists/:id, /api/playlists, /api/search, and maybe more.

@Noam-Bendelac Noam-Bendelac added backend Backend functionality frontend Frontend functionality labels Dec 29, 2020
@Noam-Bendelac Noam-Bendelac added this to the Milestone 1 milestone Dec 29, 2020
This was referenced Dec 29, 2020
Noam-Bendelac added a commit that referenced this issue May 23, 2021
Refactor api types for track search and tracks within
`.../playlists/:id` to have just the data needed by the frontend, and
move some of the processing from the frontend in several places to the
backend in one place.

These were done together so the draft addition track's data can be
mocked in `SearchResults.tsx` `addButtonOnClick` callback. This will now
allow spotify data on removed tracks to be saved when they are removed
for #87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend functionality frontend Frontend functionality
Projects
None yet
Development

No branches or pull requests

1 participant