Fix inline accessor method bug in BcelAccessForInlineMunger #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduces #250. Signed-off-by: Alexander Kriegisch <[email protected]>
kriegaex
force-pushed
the
gh-250
branch
2 times, most recently
from
db870e5
to
9b1a219
Compare
Make sure to create one ajc$inlineAccessMethod per identically named (overloaded) private aspect method in BcelAccessForInlineMunger.createOrGetInlineAccessorForMethod. Fixes #250. Signed-off-by: Alexander Kriegisch <[email protected]>
…vable No longer report "Unable to find ASM classes", if simply an ASM processing error occurred. In that case, report "Error processing class file". Relates to #250. Signed-off-by: Alexander Kriegisch <[email protected]>
Since JDK 20, targets older than 1.8 are no longer supported by Javac. Signed-off-by: Alexander Kriegisch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to create one
ajc$inlineAccessMethodper identically named (overloaded) private aspect method inBcelAccessForInlineMunger.createOrGetInlineAccessorForMethod.Bugs1920Tests.test_GitHub_250reproduces the original problem before the bugfix and serves as a regression test.Also improve the error message in
LazyClassGen.getJavaClassBytesIncludingReweavable, i.e. no longer report "Unable to find ASM classes", if simply an ASM processing error occurred. In that case, report "Error processing class file".Fixes #250.