feat: add che-code-server editor #1958
Conversation
Signed-off-by: vitaliy-guliy <[email protected]>
Signed-off-by: vitaliy-guliy <[email protected]>
Signed-off-by: vitaliy-guliy <[email protected]>
|
Skipping CI for Draft Pull Request. |
vitaliy-guliy
added
made-with-che
vitaliy-guliy
requested review from
SDawley,
tolusha,
ibuziuk and
mkuznyetsov
as code owners
There was a problem hiding this comment.
I think you need to run the following command - https://github.com/eclipse-che/che-operator?tab=readme-ov-file#update-development-resources
can be done from the dogfooding cluster
| # Red Hat, Inc. - initial API and implementation | ||
| # | ||
|
|
||
| schemaVersion: 2.2.2 |
There was a problem hiding this comment.
At the moment every editor definition use 2.2.2.
What if we update the version for all editors in the next pull request?
There was a problem hiding this comment.
I would update it in this PR, but up-to-you
| metadata: | ||
| name: che-code-server | ||
| displayName: Visual Studio Code Server | ||
| description: Visual Studio Code server for Eclipse Che - latest |
There was a problem hiding this comment.
do we need to mention Eclipse Che here? would there be more follow up with downstreaming?
There was a problem hiding this comment.
We have to add a separate editor definition for downstream
There was a problem hiding this comment.
Eclipse Che is mentioned in every editor definition.
It is not a problem to remove it, but then I suppose we have to update all the definitions.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha, vitaliy-guliy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is written that we have to update the resources if we change any file in |
|
@tolusha do you know why the PR checks are failing? |
Signed-off-by: vitaliy-guliy <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: vitaliy-guliy <[email protected]>
|
Build 3.19 :: operator_3.x/439: Console, Changes, Git Data |
|
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8837: devspaces-operator-bundle : 3.x :: Failed in 66589130 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.19 :: operator-bundle_3.x/4409: Console, Changes, Git Data |
|
Build 3.19 :: sync-to-downstream_3.x/8719: Console, Changes, Git Data |
|
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8838: devspaces-operator-bundle : 3.x :: Failed in 66591406 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.19 :: operator-bundle_3.x/4410: Console, Changes, Git Data |
|
Build 3.19 :: sync-to-downstream_3.x/8720: Console, Changes, Git Data |
|
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8839: devspaces-operator-bundle : 3.x :: Failed in 66593815 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.19 :: operator-bundle_3.x/4411: Console, Changes, Git Data |
|
Build 3.19 :: sync-to-downstream_3.x/8721: Console, Changes, Git Data |
|
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8840: devspaces-operator-bundle : 3.x :: Failed in 66595483 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.20 :: operator-bundle_3.x/4412: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8724: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8844: devspaces-operator-bundle : 3.x :: Failed in 66597406 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.20 :: operator-bundle_3.x/4414: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8726: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8846: devspaces-operator-bundle : 3.x :: Failed in 66597577 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.20 :: operator-bundle_3.x/4415: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8727: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8847: devspaces-operator-bundle : 3.x :: Failed in 66598280 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.20 :: operator-bundle_3.x/4416: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8728: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8848: devspaces-operator-bundle : 3.x :: Failed in 66599546 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Adds new che-code-server editor that injects Visual Studio Code Command Line Interface (CLI) to the workspace, performs authentication and then creates a tunnel.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#23312
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.