Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isErrorPage() check in RestoreViewPhase fails when thrown exception has a null message #5529

Merged
merged 1 commit into from
Feb 3, 2025
Merged

isErrorPage() check in RestoreViewPhase fails when thrown exception has a null message #5529

merged 1 commit into from
Feb 3, 2025

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Nov 16, 2024

@BalusC BalusC requested review from arjantijms and mnriem November 16, 2024 16:55
@BalusC

This comment was marked as outdated.

Sign in to view
mnriem
mnriem approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests that validate all the (new) code paths?

@BalusC
Copy link
Contributor Author

BalusC commented Nov 23, 2024

Nope not yet.

@arjantijms arjantijms merged commit 30df43c into 4.0 Feb 3, 2025
3 checks passed
@arjantijms arjantijms deleted the mojarra_issue_5528_isErrorPage()_check_fails_when_handled_exception_has_null_message branch February 3, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnriem mnriem mnriem approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BalusC @mnriem @arjantijms