Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure 'postChange' is properly handled as async #66

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Ensure 'postChange' is properly handled as async #66

merged 1 commit into from
Nov 14, 2023

Conversation

martin-fleck-at
Copy link
Contributor

tortmayr
tortmayr approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@martin-fleck-at martin-fleck-at merged commit 1c47d6b into main Nov 14, 2023
5 checks passed
@martin-fleck-at martin-fleck-at deleted the issues/1162 branch November 14, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postChange is handled incorrectly in JsonRecordingCommand
2 participants
@martin-fleck-at @tortmayr