Fixed webworker startup bc elkjs hidden dependency #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Good catch!
Changes look good to me. Thanks! 👍🏼
This also fixes eclipse-glsp/glsp#1018
|
@Sakrafux This change seems to break the For now, I'm going to revert this change. Please feel free to open a new PR that fixes this issue. |
tortmayr
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the comment, but
elkjswants to instantiate workers. If noworkerFactoryis given, it tries to resolve this using a fake worker fromelk-worker.min.js, which is seemingly available when started through node, but not in a web-worker context. Since it is a dynamic import unknown to webpack, it is not bundled.Therefore, I simply assigned a simple stub, since the worker functionality of
elkjsis not needed. This enables the server to start in a worker as expected.