Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github badges #217

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Update github badges #217

merged 2 commits into from
Jun 26, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Jun 26, 2024

What it does

Update README job badges and rename PR workflow to CI

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Rename PR workflow to CI
@tortmayr tortmayr marked this pull request as ready for review June 26, 2024 08:59
@tortmayr tortmayr requested a review from martin-fleck-at June 26, 2024 08:59
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Tobias, just a minor nit: When looking at https://github.com/eclipse-glsp/glsp-theia-integration/tree/badges it seems that the backticks for next are not really rendered as you would expect, so I think we should just remove them:

image

@tortmayr
Copy link
Contributor Author

Done. Note that the badge in https://github.com/eclipse-glsp/glsp-theia-integration/tree/badges will still reference the old name (With the next).
The badges will update once the publish workflow is executed the next time (with the new name)

@tortmayr tortmayr requested a review from martin-fleck-at June 26, 2024 12:51
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit a5c0289 into master Jun 26, 2024
4 checks passed
@tortmayr tortmayr deleted the badges branch June 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants