Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest client changes #62

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Update to latest client changes #62

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f5770f
Update to latest client changes
tortmayr Jun 20, 2024
7cfdde5
Address review feedback
tortmayr Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# Eclipse GLSP VSCode Integration Changelog

## 2.2.0 - active

### Changes

- [diagram] Fix minor styling and behavioral issues when using `GLSPProjectionView` [#62](https://github.com/eclipse-glsp/glsp-vscode-integration/pull/62)

### Potentially Breaking Changes

- [protocol] Fix a bug in the client-server action forwarding that prevented proper marking and handling of server received actions [#58](https://github.com/eclipse-glsp/glsp-vscode-integration/pull/58)</br> Following classes and methods are now deprecated:
- `VsCodeGLSPModelSource`: Rebinding to a custom model source is no longer necessary. Use the default `GLSPModelSource` instead.
- `ExtensionAction`: The concept of marking actions as locally dispatched `ExtensionActions` is no longer necessary and usage is discouraged.
- `GlspVscodeConnector.sendToActiveClient`: Use `GlspVscodeConnector.dispatchAction` instead.
- `GlspVscodeConnector.setActionToClient`: Use `GlspVscodeConnector.dispatchAction` instead.

## [2.1.0 - 24/01/2024](https://github.com/eclipse-glsp/glsp-vscode-integration/releases/tag/v2.1.0)

## [2.0.0 - 14/10/2023](https://github.com/eclipse-glsp/glsp-vscode-integration/releases/tag/v2.0.0)
Expand Down
19 changes: 11 additions & 8 deletions example/workflow/extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,24 @@
"enablement": "activeCustomEditorId == 'workflow.glspDiagram'"
},
{
"command": "workflow.goToNextNode",
"title": "Go to next Node",
"command": "workflow.goToPreviousNode",
tortmayr marked this conversation as resolved.
Show resolved Hide resolved
"title": "Go to previous Node",
"icon": "$(arrow-circle-left)",
"category": "Workflow Navigation",
"enablement": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
"command": "workflow.goToPreviousNode",
"title": "Go to previous Node",
"command": "workflow.goToNextNode",
"title": "Go to next Node",
"icon": "$(arrow-circle-right)",
"category": "Workflow Navigation",
"enablement": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
"command": "workflow.showDocumentation",
"title": "Show documentation...",
"category": "Workflow Diagram",
"category": "Workflow Navigation",
"icon": "$(code-oss)",
"enablement": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
Expand Down Expand Up @@ -146,12 +149,12 @@
"group": "bookmarks"
},
{
"command": "workflow.goToNextNode",
"group": "navigation",
"command": "workflow.goToPreviousNode",
"group": "",
"when": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
"command": "workflow.goToPreviousNode",
"command": "workflow.goToNextNode",
"group": "navigation",
"when": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
Expand Down
17 changes: 10 additions & 7 deletions example/workflow/web-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,21 +61,24 @@
"enablement": "activeCustomEditorId == 'workflow.glspDiagram'"
},
{
"command": "workflow.goToNextNode",
"title": "Go to next Node",
"command": "workflow.goToPreviousNode",
"title": "Go to previous Node",
"icon": "$(arrow-circle-left)",
"category": "Workflow Navigation",
"enablement": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
"command": "workflow.goToPreviousNode",
"title": "Go to previous Node",
"command": "workflow.goToNextNode",
"title": "Go to next Node",
"icon": "$(arrow-circle-right)",
"category": "Workflow Navigation",
"enablement": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
"command": "workflow.showDocumentation",
"title": "Show documentation...",
"category": "Workflow Diagram",
"category": "Workflow Navigation",
"icon": "$(code-oss)",
"enablement": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
Expand Down Expand Up @@ -147,12 +150,12 @@
"group": "bookmarks"
},
{
"command": "workflow.goToNextNode",
"command": "workflow.goToPreviousNode",
"group": "navigation",
"when": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
{
"command": "workflow.goToPreviousNode",
"command": "workflow.goToNextNode",
"group": "navigation",
"when": "activeCustomEditorId == 'workflow.glspDiagram' && workflow.editorSelectedElementsAmount == 1"
},
Expand Down
Loading