fix(linux.net): Added check for existing file before iptables restore #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMaiero
reviewed
Oct 11, 2023
| } catch (IOException e) { | ||
| throw new KuraIOException(e, "restore() :: failed to read configuration file"); | ||
| File iptablesFile = new File(getFirewallConfigFileName()); | ||
| if (iptablesFile.exists()) { |
There was a problem hiding this comment.
Is it better to reduce the cognitive complexity to reverse the check?
if (iptablesFile.exists()) {
//maybe log as it is not the supposed state?
return;
}
...
pierantoniomerlino
force-pushed
the
fix_iptables_restore
branch
from
9598871 to
da6d61b
Compare
Signed-off-by: pierantoniomerlino <[email protected]>
pierantoniomerlino
force-pushed
the
fix_iptables_restore
branch
from
37bd04a to
fc29e15
Compare
Signed-off-by: pierantoniomerlino <[email protected]>
MMaiero
approved these changes
Oct 18, 2023
pierantoniomerlino
added a commit
that referenced
this pull request
Oct 20, 2023
…#4889) * Check for existing file before restore Signed-off-by: pierantoniomerlino <[email protected]> * Fixed comment formatting Signed-off-by: pierantoniomerlino <[email protected]> --------- Signed-off-by: pierantoniomerlino <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check before launching
iptables-restorecommand for testing the file presence.