-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest.cloudconnection.provider): Cloud Connections REST Api #4950
Merged
nicolatimeus
merged 47 commits into
eclipse-kura:develop
from
salvatore-coppola:cloud-connections-rest-api
Nov 14, 2023
Merged
feat(rest.cloudconnection.provider): Cloud Connections REST Api #4950
nicolatimeus
merged 47 commits into
eclipse-kura:develop
from
salvatore-coppola:cloud-connections-rest-api
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b23e40
to
0709f47
Compare
We should also edit the snasphots to add the new permission |
2417075
to
2a2d5cf
Compare
kura/org.eclipse.kura.util/src/main/java/org/eclipse/kura/util/service/ServiceUtil.java
Show resolved
Hide resolved
Please update copyright headers in snapshot files |
2a2d5cf
to
b991ce9
Compare
Please check sonarlint issues |
5fe7de3
to
9a6b6e4
Compare
9a6b6e4
to
a01c29d
Compare
nicolatimeus
approved these changes
Nov 14, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-5.4.0 release-5.4.0
# Navigate to the new working tree
cd .worktrees/backport-release-5.4.0
# Create a new branch
git switch --create backport-4950-to-release-5.4.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 037d68e43fe9987262a948b16f77be84bcf8827e
# Push it to GitHub
git push --set-upstream origin backport-4950-to-release-5.4.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-5.4.0 Then, create a pull request where the |
salvatore-coppola
added a commit
to salvatore-coppola/kura
that referenced
this pull request
Nov 14, 2023
…pse-kura#4950) * Added bundle skeleton * Added first code implementation. * Added some methods implementation * First partial implementation * Code cleanup * fixed line length * fixed error in bundle renaming during build. * added missing annotation * added missing annotation 2 * Full featured * Several fixes * Some variables renaming * Migrated to org.eclipse.kura.rest.configuration.api classes * commented unready module * Refactored code to reduce cognitive complexity. * Added test skeleton * Added test for `/cloudEntries` * Removed checked exceptions throwing in init. * some fixes * other fixes. * refactored according with new naming * code cleanup * Minor methods name changes * minor fixes. * Removed unused DEBUG_MESSSAGE. * Now if a stackComponent doesn't exist for a specific pid, an empty list is returned. * Changed the returned error codes. * replaced cloudServicePid with cloudEndpointPid * Added KuraErrorCode.NOT_FOUND if connectionId is not found. * Changer returned error code. * Almost finished tests. * Added all tests. * Fixed shouldDeleteCloudEndpoint * Replaced CloudService-test pid with constant. * Replace void return with `javax.ws.rs.core.Response` * Fixed test. * Added different specific PID for executions on different Transport * Fixed error in pid * Refactored tests. * Removed unused resources. * Added `rest.cloudconnection` permission to snapshot_0.xml files * Updated copyright header. * Updated year in the copyright plate. * Refactored code to remove cognitive complexity. * Fixed wrong class type * Fixed reversed fields. * Added check on managed CloudconnectionPids existence.
MMaiero
pushed a commit
that referenced
this pull request
Nov 15, 2023
…port release-5.4.0] (#4980) feat(rest.cloudconnection.provider): Cloud Connections REST Api (#4950) * Added bundle skeleton * Added first code implementation. * Added some methods implementation * First partial implementation * Code cleanup * fixed line length * fixed error in bundle renaming during build. * added missing annotation * added missing annotation 2 * Full featured * Several fixes * Some variables renaming * Migrated to org.eclipse.kura.rest.configuration.api classes * commented unready module * Refactored code to reduce cognitive complexity. * Added test skeleton * Added test for `/cloudEntries` * Removed checked exceptions throwing in init. * some fixes * other fixes. * refactored according with new naming * code cleanup * Minor methods name changes * minor fixes. * Removed unused DEBUG_MESSSAGE. * Now if a stackComponent doesn't exist for a specific pid, an empty list is returned. * Changed the returned error codes. * replaced cloudServicePid with cloudEndpointPid * Added KuraErrorCode.NOT_FOUND if connectionId is not found. * Changer returned error code. * Almost finished tests. * Added all tests. * Fixed shouldDeleteCloudEndpoint * Replaced CloudService-test pid with constant. * Replace void return with `javax.ws.rs.core.Response` * Fixed test. * Added different specific PID for executions on different Transport * Fixed error in pid * Refactored tests. * Removed unused resources. * Added `rest.cloudconnection` permission to snapshot_0.xml files * Updated copyright header. * Updated year in the copyright plate. * Refactored code to remove cognitive complexity. * Fixed wrong class type * Fixed reversed fields. * Added check on managed CloudconnectionPids existence.
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new bundle provides a REST API that allows access to the
CloudConnection
object and itsDataService
and their methods via the REST API.TODO:
org.eclipse.kura.rest.configuration.provider