Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated README with working links on shield badges #5040

Merged

Conversation

marcellorinaldo
Copy link
Contributor

Prior this PR, clicking on the badges in the README does just redirect you to the image hosted at img.shields. This PR adds some meaningful links.

Related Issue: N/A.

Description of the solution adopted: N/A.

Screenshots: N/A.

Manual Tests: N/A.

Any side note on the changes made: N/A.

@mattdibi
Copy link
Contributor

mattdibi commented Dec 1, 2023

Personally I would remove a couple of badges: do we really need the "Issues" badge when the Issues tab is a couple of pixel above the readme? Same goes for PR, contributors and forks badges...

Copy link
Contributor

@salvatore-coppola salvatore-coppola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Url checked

@salvatore-coppola salvatore-coppola merged commit 53e0672 into eclipse-kura:develop Dec 1, 2023
1 check passed
@mattdibi mattdibi deleted the fix-readme-links branch December 1, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants