test: re-enable and fix DeploymentAgentTest #5632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5602 we disabled some tests that were failing due to the Java 17 change. This PR re-enables one of them.
We were getting the following error after switching to Java 17:
This seems to be an issue with Mockito and
spy
ing Threads as per:As suggested in mockito/mockito#2628, switching to
mockito-inline
seems to fix it.Note: there seems to be another issue with this same test suite related to
mockserver
. When running these tests we get:which is related to mock-server/mockserver#1739.
This does not break our current tests because, even if it fails to decode the client certificate, it proceeds with the rest of the test anyway.