Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: org.eclipse.kura.core.configuration.CloudConfigurationHandler service #5636

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

MMaiero
Copy link
Contributor

@MMaiero MMaiero commented Jan 8, 2025

Implementation deprecation.

Not a standard API deprecation, but given the importance of the CONF-V1 implementation, it makes sense to make it as much visible as possible.
Users redirected to the usage of CONF-V2 with the /configuration/v2 REST APIs

@MMaiero MMaiero requested a review from mattdibi January 8, 2025 12:54
@MMaiero MMaiero marked this pull request as ready for review January 8, 2025 12:54
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For visibility I would update our documentation page to reflect this deprecation.

Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattdibi
Copy link
Contributor

mattdibi commented Jan 9, 2025

Sonar Quality gate is currently failing due to:

image

https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&types=CODE_SMELL&branch=PR-5636&id=org.eclipse.kura%3Akura&open=AZRL2rvU7BwCrgRwY5xt

which is caused by the code we just deprecated. I would say that it is safe to ignore.

Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MMaiero MMaiero merged commit 2cb6b9a into develop Jan 9, 2025
2 of 3 checks passed
@MMaiero MMaiero deleted the deprecate_conf-v1 branch January 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants