feat: Made PositionService dependency optional for CloudServices #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierantoniomerlino
force-pushed
the
optimize_deps_cloudservice
branch
2 times, most recently
from
09705cb to
c3b23bc
Compare
|
The sonar analysis fails for code coverage and duplication. This because the |
| @@ -1,5 +1,5 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2011, 2023 Eurotech and/or its affiliates and others | |||
| * Copyright (c) 2011, 2024 Eurotech and/or its affiliates and others | |||
marcellorinaldo
approved these changes
Jan 9, 2025
pierantoniomerlino
force-pushed
the
optimize_deps_cloudservice
branch
from
0526b41 to
01fe160
Compare
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
pierantoniomerlino
force-pushed
the
optimize_deps_cloudservice
branch
from
01fe160 to
395a95e
Compare
MMaiero
approved these changes
Jan 9, 2025
|
Forcing merge. The sonar part complains on code duplication due to the fact that the cloud bundles share a large amount of code. But this cannot be prevented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
CloudServices dependencies making thePositionServiceoptional.Related Issue: This PR fixes/closes N/A
Description of the solution adopted: In order to optimize the dependency list of the
CloudServiceimplementations, this PR removes thePoistionServicestatic dependency and makes it optional (dynamic, 0..1). Moreover, some small improvements have been done on the code. The modifications impact onlyorg.eclipse.kura.cloudconnection.kapua.mqtt.providerandorg.eclipse.kura.cloudconnection.eclipseiot.mqtt.provider.