refactor(web2): refactored snapshot and wiregraph download #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
marcellorinaldo
previously requested changes
Jan 20, 2025
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.java
Outdated
Show resolved
Hide resolved
sfiorani
commented
Jan 20, 2025
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.java
Outdated
Show resolved
Hide resolved
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.java
Outdated
Show resolved
Hide resolved
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.java
Outdated
Show resolved
Hide resolved
...e.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/wires/WiregraphDownloadModal.ui.xml
Outdated
Show resolved
Hide resolved
....eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotsTabUi.java
Outdated
Show resolved
Hide resolved
....kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.ui.xml
Outdated
Show resolved
Hide resolved
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.java
Outdated
Show resolved
Hide resolved
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/settings/SnapshotGenericModal.java
Outdated
Show resolved
Hide resolved
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
pierantoniomerlino
approved these changes
Jan 29, 2025
pierantoniomerlino
dismissed
marcellorinaldo’s stale review
This PR is blocking, so the review has been reassigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors both the snapshot and the wiregraph download front and backend. In particular the following changes are made:
1. Creation of a generic modal that allows to perform operations on the entire list of PIDs present in the framework
This modal is composed by title, two paragraph for descriptions and hints, a scrollable panel that contains a list of checkboxes representing the PIDs, an anchor that allows selection/removal of all/filtered checkboxes, a counter for the selected boxes over the total, a modalFooter to add buttons or other items.
The aim of this modal is to perform operations that may involve the entire list of PIDs on the framework, or just a subset of them. In this way, the generic modal can just be extended wherever in the code to adapt it on the specific application.
2. Migration of the Snapshot Download modal on the generic one
The snapshot download modal is now an extension of the generic modal explained in point 1.
3. Refactor of the Wiregraph Download modal
The wiregraph download was a huge customization of the Snapshot Download modal. Now the wiregraph modal is an independent one, in the correct bundle.
Also the download request to the servlet was turned from a GET (using the native js code from the DownloadHelper class to a POST one including the token and the format in the body request.
This last change is in line with the purpose of suppressing the js native code from the DownloadHelper class.
From the user POV the experience is not changed, it' just a backend reorganization.
Screenshots:
