Added setting to disable files in completion settings #1180
Conversation
Signed-off-by: Alexander Chen <[email protected]>
| @@ -26,13 +26,16 @@ | |||
|
|
|||
| private boolean autoCloseRemovesContent; | |||
|
|
|||
| public XMLCompletionSettings(boolean autoCloseTags, boolean autoCloseRemovesContent) { | |||
| private boolean fileCompletion; | |||
There was a problem hiding this comment.
This settings belongs to the file path extension, so please don't add that in this class. I suggest that you see sample like https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/settings/ContentModelSettings.java
In other words, you should create a settings/FilePathSettings.java in https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/general
Please rename general to filepath to have org.eclipse.lemminx.extensions.filepath instead of org.eclipse.lemminx.extensions.general package and update too https://github.com/eclipse/lemminx/blob/1a70ccf0434354dee821e5e5f8111277378a57b4/org.eclipse.lemminx/src/main/resources/META-INF/services/org.eclipse.lemminx.services.extensions.IXMLExtension#L9
|
Fixed with #1293 |
Added setting to disable files in completion settings.
Part of redhat-developer/vscode-xml/issues/670
Signed-off-by: Alexander Chen [email protected]