Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure start behavior of logback-class through m2e.logback.feature #1512

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

HannesWell
Copy link
Contributor

and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback:
apache/aries#233

Fixes #1481

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Test Results

106 files  ±0  106 suites  ±0   10m 4s ⏱️ +2s
660 tests ±0  650 ✔️ ±0  10 💤 ±0  0 ±0 
660 runs  ±0  649 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 0e854a7. ± Comparison against base commit cf3505f.

♻️ This comment has been updated with latest results.

Comment on lines 1 to 22
#create a requirement on the fragment we are creating
requires.0.namespace=org.eclipse.equinox.p2.iu
requires.0.name=configure.logback.classis
requires.0.range=[$version$,$version$]
requires.0.greedy=true

#create a IU fragment named configure.logback.classis
units.0.id=configure.logback.classis
units.0.version=$version$
units.0.provides.1.namespace=org.eclipse.equinox.p2.iu
units.0.provides.1.name=configure.logback.classis
units.0.provides.1.version=$version$
units.0.instructions.configure=setStartLevel(startLevel:2);\
markStarted(started:true);
units.0.hostRequirements.1.namespace=osgi.bundle
units.0.hostRequirements.1.name=ch.qos.logback.classic
units.0.hostRequirements.1.range=[1.3,1.5]
units.0.hostRequirements.1.greedy=false
units.0.requires.1.namespace=osgi.bundle
units.0.requires.1.name=ch.qos.logback.classic
units.0.requires.1.range=[1.3,1.5]
units.0.requires.1.greedy=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laeubi can you tell what I'm doing wrong here?
I want to set the ch.qos.logback.classic bundle as auto-started with level 2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i rember correctly you need to include the p2.inf into the build.properties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that was definitely missing.
What was also missing was the installBundle(bundle:${artifact}). Otherwise logback.classic was just removed from the bundles.info file.

and add 'jakarta.servlet-api' as requirement to ensure its present until
Aries can handle its absense for logback:
apache/aries#233

Fixes eclipse-m2e#1481
@HannesWell
Copy link
Contributor Author

HannesWell commented Aug 18, 2023

@HannesWell
Copy link
Contributor Author

Testing the result looked good as far as m2e can influence it. Everything else needs to be handled by others.

@HannesWell HannesWell merged commit 002fca8 into eclipse-m2e:master Aug 19, 2023
4 of 5 checks passed
@HannesWell HannesWell deleted the logbackConfiguration branch August 19, 2023 12:20
@HannesWell HannesWell added this to the 2.4.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty maven console in 2023-06
2 participants