-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure start behavior of logback-class through m2e.logback.feature #1512
Configure start behavior of logback-class through m2e.logback.feature #1512
Conversation
#create a requirement on the fragment we are creating | ||
requires.0.namespace=org.eclipse.equinox.p2.iu | ||
requires.0.name=configure.logback.classis | ||
requires.0.range=[$version$,$version$] | ||
requires.0.greedy=true | ||
|
||
#create a IU fragment named configure.logback.classis | ||
units.0.id=configure.logback.classis | ||
units.0.version=$version$ | ||
units.0.provides.1.namespace=org.eclipse.equinox.p2.iu | ||
units.0.provides.1.name=configure.logback.classis | ||
units.0.provides.1.version=$version$ | ||
units.0.instructions.configure=setStartLevel(startLevel:2);\ | ||
markStarted(started:true); | ||
units.0.hostRequirements.1.namespace=osgi.bundle | ||
units.0.hostRequirements.1.name=ch.qos.logback.classic | ||
units.0.hostRequirements.1.range=[1.3,1.5] | ||
units.0.hostRequirements.1.greedy=false | ||
units.0.requires.1.namespace=osgi.bundle | ||
units.0.requires.1.name=ch.qos.logback.classic | ||
units.0.requires.1.range=[1.3,1.5] | ||
units.0.requires.1.greedy=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laeubi can you tell what I'm doing wrong here?
I want to set the ch.qos.logback.classic
bundle as auto-started with level 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i rember correctly you need to include the p2.inf into the build.properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that was definitely missing.
What was also missing was the installBundle(bundle:${artifact})
. Otherwise logback.classic was just removed from the bundles.info
file.
301fb60
to
289f489
Compare
and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback: apache/aries#233 Fixes eclipse-m2e#1481
289f489
to
0e854a7
Compare
In my local testing with a local build this now worked. But I'll try again tomorrow with the IDE build in the CI. Some supporting documentation can be found here: |
Testing the result looked good as far as m2e can influence it. Everything else needs to be handled by others. |
and add 'jakarta.servlet-api' as requirement to ensure its present until Aries can handle its absense for logback:
apache/aries#233
Fixes #1481