Make sure the last modified timestamp is set correctly #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
fix_timestmap_compare
branch
from
e1f822c
to
c5019d3
Compare
laeubi
force-pushed
the
fix_timestmap_compare
branch
from
c5019d3
to
dcc14e9
Compare
|
The test failure was that if the artifact was already wrapped once with error it might be still created (bnds principle is to never really 'fail' but only emit an error/warning), so the second time it finds the cache file and proceeds without an error. I now choose to simply delete the result file in case of an error, a more sophisticated approach might would store the error message along with the cached file but this has some uncertainties e.g if the error was not caused by the artifact itself so this seems the safe and easy path for now as one should not optimize for the error case. |
Linux stores modification time with nano-seconds precision, but we currently set the timestamp of the cached file only in milliseconds. This can lead to the situation that the source is considered a few nanoseconds older than the cache file and therefore the cache is regenerated every time.
laeubi
force-pushed
the
fix_timestmap_compare
branch
from
dcc14e9
to
d0396e3
Compare
HannesWell
approved these changes
Aug 20, 2023
| if (jar != null) { | ||
| jar.close(); | ||
| } | ||
| wrap.getJar().ifPresent(jar -> jar.close()); |
There was a problem hiding this comment.
You could probably use a Method reference here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux stores modification time with nano-seconds precision, but we currently set the timestamp of the cached file only in milliseconds. This can lead to the situation that the source is considered a few nanoseconds older than the cache file and therefore the cache is regenerated every time.