Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Launch EnrichPom.java as source program in Maven publication #2742

Conversation

HannesWell
Copy link
Member

This leverages the ability to launch multi-file source-code programs add in Java-22 via JEP-458:

Technically it's not a problem to use JDK-23 or 24 (as soon as it's released) in this internal part of the build, yet I still hesitate with this because I worry a bit that it might be forgotten to update the JDK tool as soon as the non-LTS releases are out of maintenance since we usually don't use them anywhere else and it's therefore not on our TODO-list.

This leverages the ability to launch multi-file source-code programs add
in Java-22 via JEP-458:
- https://openjdk.org/jeps/458
@HannesWell
Copy link
Member Author

I still hesitate with this because I worry a bit that it might be forgotten to update the JDK tool as soon as the non-LTS releases are out of maintenance since we usually don't use them anywhere else and it's therefore not on our TODO-list.

Alternatively we could simply leave this PR open until JDK-25 is released in autumn of this year. Since this is just an internal RelEng usage we don't have to follow any rules regarding usage of new JDK versions.

Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of jobs that are still on 17 or even 11 even though 21 is required by Eclipse now (aka "forgotten") and IMO we will always have such so having one on Java 23 doesn't out weight the improved readability of the job itself.

@HannesWell
Copy link
Member Author

HannesWell commented Jan 12, 2025

There are a bunch of jobs that are still on 17 or even 11 even though 21 is required by Eclipse now (aka "forgotten") and IMO we will always have such so having one on Java 23 doesn't out weight the improved readability of the job itself.

That's right. Ok, lets have this now and I try to remember to update this when JDK 24 and 25 are released.

@HannesWell HannesWell merged commit 88a98bd into eclipse-platform:master Jan 12, 2025
4 checks passed
@HannesWell HannesWell deleted the maven-publication-enrich-POM-as-source branch January 12, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants