Guard Image Type Icon from Smooth Scaling

[ShahzaibIbrahim]

Enabling the smooth scaling for icon produce erroneous result. Resulting in icon losing its transparency.

How to Test

Use the snippet to see the difference in behavior of the Image and Icon during the DPI change.

Display display = new Display();
Shell shell = new Shell(display);
shell.setText("Image and Icon Example");
shell.setLayout(new RowLayout());

Image icon = display.getSystemImage(SWT.ICON_WORKING);
InputStream is = ImageExample.class.getResourceAsStream("eclipse.png");
Image image = new Image(display, is);

new Label(shell, SWT.NONE).setImage(icon);
new Label(shell, SWT.NONE).setImage(image);
shell.pack();

shell.open();

while (!shell.isDisposed()) {
	if (!display.readAndDispatch()) {
		display.sleep();
	}
}
display.dispose();

• Run the snippet with -Dswt.autoScale.updateOnRuntime=true
• Move the shell from primary (100%) monitor to secondary (200%) Or use any other combination of zooms
• See if the icons losing transparency.

Before Fix

After Fix

Note: Image is only added in snippet to show smooth scaling still applicable for bitmap images.

[github-actions]

Test Results

   502 files  ±0     502 suites  ±0   10m 32s ⏱️ - 5m 20s
 4 334 tests ±0   4 320 ✅ ±0   14 💤 ±0  0 ❌ ±0 
16 575 runs  ±0  16 466 ✅ ±0  109 💤 ±0  0 ❌ ±0 

Results for commit 5448e5d. ± Comparison against base commit cc07c36.

♻️ This comment has been updated with latest results.