Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gradients usage in new Wizard #2720

Open
vogella opened this issue Jan 17, 2025 · 8 comments
Open

Reduce gradients usage in new Wizard #2720

vogella opened this issue Jan 17, 2025 · 8 comments
Labels
enhancement New feature or request

Comments

@vogella
Copy link
Contributor

vogella commented Jan 17, 2025

I think the gradients in our wizard look bad and I suggest we reduce the usage of them.

Image

IIRC I also saw a statement from @Michael5601 that this would also be faster, once his SVG support is implemented and used.

So IMHO without the gradients the wizard would look nicer and if upcoming SVG they would also faster to be loaded.

For an example without gradient, looks at the Maven wizards:

Image

@BeckerWdf WDYT?

@vogella vogella added the enhancement New feature or request label Jan 17, 2025
@vogella
Copy link
Contributor Author

vogella commented Jan 17, 2025

See also #2721

@merks
Copy link
Contributor

merks commented Jan 17, 2025

It looks bad that the image touches the top. Is that related or just somewhat poor icon design?

@Michael5601
Copy link

These wizard icons are all very detailed. I think this is due to the larger size in which they are presented compared to all other icons. I am also in favor of simplifying them and this is also my opinion for all other icons too.
But for the wizard icons alone we won't see a significant performance improvement when using SVGs as they only have limited usage.

@vogella
Copy link
Contributor Author

vogella commented Jan 17, 2025

It looks bad that the image touches the top. Is that related or just somewhat poor icon design?

I think it is the icon design. Of course you can define a icon without gradients without starting at the top.

@BeckerWdf
Copy link
Contributor

For an example without gradient, looks at the Maven wizards

This icon anyway does not comply to the current eclipse style guide. Even if we don't like the current style we should stick to it so that the application looks consistent...

@vogella
Copy link
Contributor Author

vogella commented Jan 18, 2025

Please link to the corresponding style guide section

@merks
Copy link
Contributor

merks commented Jan 18, 2025

@laeubi
Copy link
Contributor

laeubi commented Jan 18, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants