-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce gradients usage in new Wizard #2720
Comments
See also #2721 |
It looks bad that the image touches the top. Is that related or just somewhat poor icon design? |
These wizard icons are all very detailed. I think this is due to the larger size in which they are presented compared to all other icons. I am also in favor of simplifying them and this is also my opinion for all other icons too. |
I think it is the icon design. Of course you can define a icon without gradients without starting at the top. |
This icon anyway does not comply to the current eclipse style guide. Even if we don't like the current style we should stick to it so that the application looks consistent... |
Please link to the corresponding style guide section |
I'm not sure where this lives now: https://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html#WizSpecsSize_VDG |
Source: https://github.com/eclipse-platform/ui-best-practices |
I think the gradients in our wizard look bad and I suggest we reduce the usage of them.
IIRC I also saw a statement from @Michael5601 that this would also be faster, once his SVG support is implemented and used.
So IMHO without the gradients the wizard would look nicer and if upcoming SVG they would also faster to be loaded.
For an example without gradient, looks at the Maven wizards:
@BeckerWdf WDYT?
The text was updated successfully, but these errors were encountered: