Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheat Sheet wizard icon looks bad in dark theme #2721

Closed
vogella opened this issue Jan 17, 2025 · 5 comments · Fixed by eclipse-pde/eclipse.pde#1571
Closed

Cheat Sheet wizard icon looks bad in dark theme #2721

vogella opened this issue Jan 17, 2025 · 5 comments · Fixed by eclipse-pde/eclipse.pde#1571
Assignees
@BeckerWdf
Labels
bug Something isn't working
Milestone
4.35 M2

Comments

@vogella
Copy link
Contributor

vogella commented Jan 17, 2025

The background of the cheat sheet wizard is still white. He should set it to transparent (and if possible remove the ugly gradient).

Image

@BeckerWdf can you take this one?
@vogella vogella added the bug Something isn't working label Jan 17, 2025
@vogella vogella mentioned this issue Jan 17, 2025
Open
@BeckerWdf
Copy link
Contributor

Where can I find this icon?

@BeckerWdf
Copy link
Contributor

Image

it's in pde.ui
and it's a PNG but we don't have a SVG for it. So that was somehow overlooked.
I will see if I can provide an SVG for that.

@BeckerWdf
Copy link
Contributor

what about this:

Image

?

BeckerWdf added a commit to BeckerWdf/eclipse.pde that referenced this issue Jan 17, 2025
@BeckerWdf
Fix "New Cheat Cheat" Wizard Banner Image
f9febb4 
- Remove white background
- Add high resolution version of the image
- Delete unused copy of the image

Fixes: eclipse-platform/eclipse.platform.ui#2721
BeckerWdf added a commit to BeckerWdf/eclipse.platform.images that referenced this issue Jan 17, 2025
@BeckerWdf
Fix "New Cheat Cheat" Wizard Banner Image
8d646cf 
- Remove white background
- Add high resolution version of the image
- Delete unused copy of the image

See: eclipse-platform/eclipse.platform.ui#2721
This was referenced Jan 17, 2025
Merged
Merged
@vogella
Copy link
Contributor Author

vogella commented Jan 17, 2025

what about this:

Image ?

I would prefer without the gradient but this is the discussion in #2720

vogella pushed a commit to eclipse-platform/eclipse.platform.images that referenced this issue Jan 17, 2025
@BeckerWdf @vogella
Fix "New Cheat Cheat" Wizard Banner Image
deafea9 
- Remove white background
- Add high resolution version of the image
- Delete unused copy of the image

See: eclipse-platform/eclipse.platform.ui#2721
@vogella
Copy link
Contributor Author

vogella commented Jan 17, 2025

Thanks @BeckerWdf

@BeckerWdf BeckerWdf changed the title Check Sheet wizard icon looks bad in dark theme Cheat Sheet wizard icon looks bad in dark theme Jan 18, 2025
@BeckerWdf BeckerWdf self-assigned this Jan 18, 2025
@BeckerWdf BeckerWdf added this to the 4.35 M2 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeckerWdf BeckerWdf

Labels
bug Something isn't working
Projects
None yet
Milestone
4.35 M2
Development

Successfully merging a pull request may close this issue.

Fix "New Cheat Cheat" Wizard Banner Image BeckerWdf/eclipse.pde
2 participants
@vogella @BeckerWdf