Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution #133
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't CompoundContributionItem be used directly by clients? |
Yes, but the classes to access marker grouping information are internal i.e. see GroupsContribution.getContributionItems(). |
eobrienPilz
force-pushed
the
578581_GroupsContribution
branch
from
b3ce459 to
d6fa22e
Compare
eobrienPilz
force-pushed
the
578581_GroupsContribution
branch
2 times, most recently
from
6298298 to
e7a6202
Compare
eobrienPilz
added a commit
to eobrienPilz/eclipse.platform.ui
that referenced
this pull request
Sep 20, 2024
…nal GroupsContribution eclipse-platform#133 Squashed commit of the following: commit e7a6202 Author: Enda O Brien <[email protected]> Date: Mon Jun 13 11:26:11 2022 +0100 Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution
eobrienPilz
force-pushed
the
578581_GroupsContribution
branch
from
e7a6202 to
1d2dc6e
Compare
eobrienPilz
added a commit
to eobrienPilz/eclipse.platform.ui
that referenced
this pull request
Sep 24, 2024
…nal GroupsContribution eclipse-platform#133 Squashed commit of the following: commit 1d2dc6e Author: Enda O Brien <[email protected]> Date: Fri Sep 20 17:18:06 2024 +0100 Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution eclipse-platform#133 Squashed commit of the following: commit e7a6202 Author: Enda O Brien <[email protected]> Date: Mon Jun 13 11:26:11 2022 +0100 Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution
eobrienPilz
force-pushed
the
578581_GroupsContribution
branch
from
5062936 to
0c90458
Compare
…nal GroupsContribution eclipse-platform#133 Squashed commit of the following: commit 1d2dc6e Author: Enda O Brien <[email protected]> Date: Fri Sep 20 17:18:06 2024 +0100 Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution eclipse-platform#133 Squashed commit of the following: commit e7a6202 Author: Enda O Brien <[email protected]> Date: Mon Jun 13 11:26:11 2022 +0100 Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution
eobrienPilz
force-pushed
the
578581_GroupsContribution
branch
from
0c90458 to
c2345eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch submission for the bugzilla issue here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=578581
The proposal is to have an API equivalent of the ContributionItem for Marker groups.
This will allow clients to create their own custom groupings.
Note: Creating the custom groupings was always possible but relied on referencing the internal GroupsContribution in the xml definition.