579498 filter dialog types #144

eobrienPilz · 2022-06-16T16:27:00Z

We have a customized problem view for our application.
It displays markers of our own type pilzproblemmarker

i.e.

Defined like this.
<extension point="org.eclipse.core.resources.markers" id="pilzproblemmarker" name="pilz problem marker"> <super type="org.eclipse.core.resources.problemmarker"> </super> .......

We associate it with the problem view like this.
<extension point="org.eclipse.ui.ide.markerSupport"> id="com.pilz.pas.platform.gui.pilzproblemmarker"/>

We create our markers like this with our custom marker as a super.
<extension point="org.eclipse.core.resources.markers" id="com.pilz.pas.hal.errorhandling.ErrorCodes.STATEMENT_INDEX_OUT_OF_BOUNDS" name="%SUPPRESSION_MSG_STATEMENT_INDEX_OUT_OF_BOUNDS"> <super type="com.pilz.pas.platform.gui.pilzproblemmarker"> </super> .......

This works well with the filter dialog.

All our markers get displayed in the type section of the filter dialog.
Other problem markers that we don't care about (e.g. Java problems) are not displayed.

Only issue is that the supertype pilzproblemmarker is shown : see the screenshot
We need to hide it.

eobrienPilz · 2022-06-16T16:32:12Z

Link to the bugzilla issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=579498

I just added a comment there describing the patch proposal

jukzi

The version in the Manifest needs to be updated.

16:42:27.335 [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.ui.ide: Only qualifier changed for (org.eclipse.ui.ide/3.19.0.v20220610-1747). Expected to have bigger x.y.z than what is available in baseline (3.19.0.v20220511-1638) -> [Help 1]

I do not understand the issue - could you provide screenshots before/after?
new files need a copyright in the header
please avoid newline changes.

API

eobrienPilz · 2022-08-24T11:07:47Z

The version in the Manifest needs to be updated.

16:42:27.335 [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.ui.ide: Only qualifier changed for (org.eclipse.ui.ide/3.19.0.v20220610-1747). Expected to have bigger x.y.z than what is available in baseline (3.19.0.v20220511-1638) -> [Help 1]

I do not understand the issue - could you provide screenshots before/after?

new files need a copyright in the header

please avoid newline changes.

API

Are there guidelines somewhere on what the version should be ?

Should I change from
Bundle-Version: 3.19.0.qualifier
to
Bundle-Version: 3.19.1.qualifier

jukzi · 2022-08-24T11:33:35Z

Bundle-Version: 3.19.1.qualifier

we increase by 100. see https://wiki.eclipse.org/Version_Numbering#When_to_change_the_service_segment
3.19.100

tests/org.eclipse.ui.tests/plugin.xml

bundles/org.eclipse.ui.ide/schema/markerSupport.exsd

eobrienPilz · 2022-08-24T13:12:24Z

Bundle-Version: 3.19.1.qualifier

we increase by 100. see https://wiki.eclipse.org/Version_Numbering#When_to_change_the_service_segment 3.19.100

Reading the wiki its still not clear if it should be a minor change or a service change. The extension point has changed so I thought maybe it should be minor. However if I increase minor to 3.20.0 I get an error from API Analysis in eclipse saying there is no API change.

jukzi · 2022-08-24T13:29:36Z

Reading the wiki its still not clear if it should be a minor change or a service change. The extension point has changed so I thought maybe it should be minor. However if I increase minor to 3.20.0 I get an error from API Analysis in eclipse saying there is no API change.

It's not a binary break that the API Analysis detects. However it is an API change. Some guru can force an increase to 3.20 but let's wait if others agree about that change.

...org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/ContentGeneratorDescriptor.java

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/SubTypeOnlyTestView.java

jukzi

LGTM (did not test it though) - @mickaelistria API change needs more reviewers

github-actions · 2023-04-19T11:42:43Z

Test Results

1 818 files + 3 1 818 suites +3 1h 41m 29s ⏱️ + 3m 33s
7 708 tests + 4 7 480 ✅ + 5 228 💤 ±0 0 ❌ - 1
24 285 runs +12 23 538 ✅ +13 747 💤 ±0 0 ❌ - 1

Results for commit 7401cf7. ± Comparison against base commit a431d71.

♻️ This comment has been updated with latest results.

…-platform#144) * Add filtering support for duplicate files in nested projects - add filter to File Search to remove duplicate file entries that are attributed to different projects in a nested project scenario - fixes eclipse-platform#143

Squashed commit of the following: commit 94f352d Author: Enda O Brien <[email protected]> Date: Thu Apr 4 17:07:02 2024 +0100 Fixed a couple of warnings in test code commit 49a195d Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:54:38 2022 +0100 put add and addAll back in previous order commit 7dd8032 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:11:23 2022 +0100 Moved copyright to be first lines in files commit 87763b5 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:41:46 2022 +0100 Modified copyright message in test code to include my name commit 1b08d4a Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:09:12 2022 +0100 updated documentation of markerSupport.exsd commit 579fca0 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 12:04:44 2022 +0100 Added copyright notice to test code commit 1271c95 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 11:49:13 2022 +0100 Fixed whitespace differences commit 36e50cd Author: Enda O Brien <[email protected]> Date: Thu Jun 9 14:16:44 2022 +0100 Test code for application attribute on marker type reference commit 01940b2 Author: Enda O Brien <[email protected]> Date: Thu Jun 9 10:57:55 2022 +0100 Added application attribute to type reference in marker content generator

Squashed commit of the following: commit 24db6db Author: Enda O Brien <[email protected]> Date: Fri Sep 20 13:19:55 2024 +0100 579498 filter dialog types eclipse-platform#144 Squashed commit of the following: commit 94f352d Author: Enda O Brien <[email protected]> Date: Thu Apr 4 17:07:02 2024 +0100 Fixed a couple of warnings in test code commit 49a195d Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:54:38 2022 +0100 put add and addAll back in previous order commit 7dd8032 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:11:23 2022 +0100 Moved copyright to be first lines in files commit 87763b5 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:41:46 2022 +0100 Modified copyright message in test code to include my name commit 1b08d4a Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:09:12 2022 +0100 updated documentation of markerSupport.exsd commit 579fca0 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 12:04:44 2022 +0100 Added copyright notice to test code commit 1271c95 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 11:49:13 2022 +0100 Fixed whitespace differences commit 36e50cd Author: Enda O Brien <[email protected]> Date: Thu Jun 9 14:16:44 2022 +0100 Test code for application attribute on marker type reference commit 01940b2 Author: Enda O Brien <[email protected]> Date: Thu Jun 9 10:57:55 2022 +0100 Added application attribute to type reference in marker content generator

.../org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/NoApplicationAttribTestView.java

jukzi

Overall it still looks good to me. May be you can just apply my last comments and then this is good to merge if nobody insists.

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/TypeAndSubTypeTestView.java

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/markers/MarkerTypeTests.java

Squashed commit of the following: commit 24db6db Author: Enda O Brien <[email protected]> Date: Fri Sep 20 13:19:55 2024 +0100 579498 filter dialog types eclipse-platform#144 Squashed commit of the following: commit 94f352d Author: Enda O Brien <[email protected]> Date: Thu Apr 4 17:07:02 2024 +0100 Fixed a couple of warnings in test code commit 49a195d Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:54:38 2022 +0100 put add and addAll back in previous order commit 7dd8032 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:11:23 2022 +0100 Moved copyright to be first lines in files commit 87763b5 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:41:46 2022 +0100 Modified copyright message in test code to include my name commit 1b08d4a Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:09:12 2022 +0100 updated documentation of markerSupport.exsd commit 579fca0 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 12:04:44 2022 +0100 Added copyright notice to test code commit 1271c95 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 11:49:13 2022 +0100 Fixed whitespace differences commit 36e50cd Author: Enda O Brien <[email protected]> Date: Thu Jun 9 14:16:44 2022 +0100 Test code for application attribute on marker type reference commit 01940b2 Author: Enda O Brien <[email protected]> Date: Thu Jun 9 10:57:55 2022 +0100 Added application attribute to type reference in marker content generator

commit f67c61a Author: Enda O Brien <[email protected]> Date: Tue Sep 24 14:40:50 2024 +0100 579498 filter dialog types eclipse-platform#144 Squashed commit of the following: commit 24db6db Author: Enda O Brien <[email protected]> Date: Fri Sep 20 13:19:55 2024 +0100 579498 filter dialog types eclipse-platform#144 Squashed commit of the following: commit 94f352d Author: Enda O Brien <[email protected]> Date: Thu Apr 4 17:07:02 2024 +0100 Fixed a couple of warnings in test code commit 49a195d Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:54:38 2022 +0100 put add and addAll back in previous order commit 7dd8032 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 15:11:23 2022 +0100 Moved copyright to be first lines in files commit 87763b5 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:41:46 2022 +0100 Modified copyright message in test code to include my name commit 1b08d4a Author: Enda O Brien <[email protected]> Date: Wed Aug 24 14:09:12 2022 +0100 updated documentation of markerSupport.exsd commit 579fca0 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 12:04:44 2022 +0100 Added copyright notice to test code commit 1271c95 Author: Enda O Brien <[email protected]> Date: Wed Aug 24 11:49:13 2022 +0100 Fixed whitespace differences commit 36e50cd Author: Enda O Brien <[email protected]> Date: Thu Jun 9 14:16:44 2022 +0100 Test code for application attribute on marker type reference commit 01940b2 Author: Enda O Brien <[email protected]> Date: Thu Jun 9 10:57:55 2022 +0100 Added application attribute to type reference in marker content generator

jukzi requested changes Aug 23, 2022

View reviewed changes

jukzi reviewed Aug 24, 2022

View reviewed changes

tests/org.eclipse.ui.tests/plugin.xml Outdated Show resolved Hide resolved

jukzi requested changes Aug 24, 2022

View reviewed changes

bundles/org.eclipse.ui.ide/schema/markerSupport.exsd Show resolved Hide resolved

jukzi reviewed Aug 24, 2022

View reviewed changes

jukzi approved these changes Aug 24, 2022

View reviewed changes

jukzi force-pushed the 579498_FilterDialogTypes branch from 3d05345 to ae95e8a Compare April 19, 2023 11:21

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from ae95e8a to 49a195d Compare April 4, 2024 15:08

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from 94f352d to 24db6db Compare September 20, 2024 12:26

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from 24db6db to 99c91af Compare September 24, 2024 13:41

eobrienPilz requested a review from jukzi October 9, 2024 09:10

jukzi reviewed Oct 9, 2024

View reviewed changes

.../org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/NoApplicationAttribTestView.java Outdated Show resolved Hide resolved

jukzi reviewed Oct 9, 2024

View reviewed changes

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/TypeAndSubTypeTestView.java Outdated Show resolved Hide resolved

jukzi reviewed Oct 9, 2024

View reviewed changes

tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/markers/MarkerTypeTests.java Show resolved Hide resolved

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from 99c91af to 96de6e5 Compare October 9, 2024 13:04

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from 96de6e5 to 8e7ce21 Compare October 9, 2024 13:14

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from 8e7ce21 to 6c2873f Compare October 9, 2024 13:16

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from 6c2873f to f67c61a Compare October 9, 2024 14:31

eobrienPilz force-pushed the 579498_FilterDialogTypes branch from f67c61a to 7401cf7 Compare October 10, 2024 10:05

eobrienPilz requested a review from jukzi October 10, 2024 11:04

jukzi merged commit d50e66d into eclipse-platform:master Oct 10, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

579498 filter dialog types #144

579498 filter dialog types #144

eobrienPilz commented Jun 16, 2022 •

edited

Loading

eobrienPilz commented Jun 16, 2022

jukzi left a comment

eobrienPilz commented Aug 24, 2022

jukzi commented Aug 24, 2022

eobrienPilz commented Aug 24, 2022

jukzi commented Aug 24, 2022

jukzi left a comment

github-actions bot commented Apr 19, 2023 •

edited

Loading

jukzi left a comment

579498 filter dialog types #144

579498 filter dialog types #144

Conversation

eobrienPilz commented Jun 16, 2022 • edited Loading

eobrienPilz commented Jun 16, 2022

jukzi left a comment

Choose a reason for hiding this comment

eobrienPilz commented Aug 24, 2022

jukzi commented Aug 24, 2022

eobrienPilz commented Aug 24, 2022

jukzi commented Aug 24, 2022

jukzi left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 19, 2023 • edited Loading

Test Results

jukzi left a comment

Choose a reason for hiding this comment

eobrienPilz commented Jun 16, 2022 •

edited

Loading

github-actions bot commented Apr 19, 2023 •

edited

Loading