-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StickyScrolling] Refactoring sticky lines provider and handler #2266
Merged
Christopher-Hermann
merged 1 commit into
eclipse-platform:master
from
Christopher-Hermann:stickyScrollingRefactoring
Sep 26, 2024
Merged
[StickyScrolling] Refactoring sticky lines provider and handler #2266
Christopher-Hermann
merged 1 commit into
eclipse-platform:master
from
Christopher-Hermann:stickyScrollingRefactoring
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Hermann
force-pushed
the
stickyScrollingRefactoring
branch
from
September 13, 2024 11:27
07564bf
to
993bf16
Compare
Test Results 1 815 files ±0 1 815 suites ±0 1h 33m 34s ⏱️ - 2m 3s Results for commit 91997cd. ± Comparison against base commit c603575. This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Failing test is unrelated. |
I just read through very briefly.. |
Refactors the sticky lines provider and extract the method to an interface. This is a preparation step for providing a extension point for sticky lines provider.
Christopher-Hermann
force-pushed
the
stickyScrollingRefactoring
branch
from
September 25, 2024 19:14
510a50f
to
91997cd
Compare
BeckerWdf
approved these changes
Sep 26, 2024
...pse.ui.editors/src/org/eclipse/ui/internal/texteditor/stickyscroll/IStickyLinesProvider.java
Show resolved
Hide resolved
Christopher-Hermann
merged commit Sep 26, 2024
0fa0c4b
into
eclipse-platform:master
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the sticky lines provider and extract the method to an interface. This is a preparation step for providing a extension point for sticky lines provider.