[test] delete ControlObservableValueTest.png after test

[jukzi]

2MB artifact in i builds

[jukzi]

@HeikoKlare what is that png for? it is saved in ever build. for example
https://download.eclipse.org/eclipse/downloads/drops4/I20240916-1800/testresults/ep434I-unit-mac64-java17_macosx.cocoa.x86_64_17/org.eclipse.jface.tests.internal.databinding.swt.ControlObservableValueTest.ControlObservableValueTest.png

[github-actions]

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 36m 58s ⏱️ - 7m 5s
 7 699 tests ±0   7 470 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 258 runs  ±0  23 510 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 8fe03bc. ± Comparison against base commit 8d647ea.

♻️ This comment has been updated with latest results.

[akurtakov]

Screenshots like this are generally a "debugging" tool when trying to fix UI test. If they are deleted like that they can not be inspected so it's probably better to not generate them at all.

[jukzi]

If the test fails the screenshots remain as artifact. That could be useful. Maybe better they would only be generated on fail?

[akurtakov]

If the test fails the screenshots remain as artifact. That could be useful. Maybe better they would only be generated on fail?

If you manage to do that it would be awecome.

[jukzi]

ignoring unrelated Download of osgi.bundle,org.eclipse.jface.examples.databinding,1.4.400.v20240424-0956 failed on linux

[HeikoKlare]

what is that png for? it is saved in ever build. for example

Screenshots like this are generally a "debugging" tool when trying to fix UI test.

The places where screenshots are saved that I have seen so far are for documenting and debugging inproper focus handling, like here:

eclipse.platform.ui/tests/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/internal/findandreplace/FindReplaceUITest.java

Lines 84 to 87 in be54f35

	if (!dialog.hasFocus()) {
	String screenshotPath= ScreenshotTest.takeScreenshot(FindReplaceUITest.class, testName.getMethodName(), System.out);
	fail("this test does not work on GTK unless the runtime workbench has focus. Screenshot: " + screenshotPath);
	}

So your fix to only save the screenshot in case the failure that needs to be analyzed via that screenshot occurs is the right thing to do.