Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not run link handler registration in test execution #2306

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Not run link handler registration in test execution #2306

merged 1 commit into from
Oct 4, 2024

Conversation

BeckerWdf
Copy link
Contributor

No description provided.

@BeckerWdf
Copy link
Contributor Author

This PR depends on #2302

@BeckerWdf BeckerWdf mentioned this pull request Sep 20, 2024
Closed
@BeckerWdf BeckerWdf requested a review from sratz September 20, 2024 12:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 30m 10s ⏱️ - 11m 11s
 7 704 tests ±0   7 475 ✅ ±0  228 💤 ±0  1 ❌ ±0 
24 273 runs  ±0  23 525 ✅ ±0  747 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 1d50b54. ± Comparison against base commit ebbc32d.

♻️ This comment has been updated with latest results.

@BeckerWdf BeckerWdf force-pushed the not_run_link_handler_registration_in_test_execution branch from 6b86521 to f9ba59b Compare September 24, 2024 07:57
@BeckerWdf BeckerWdf self-assigned this Sep 24, 2024
@BeckerWdf BeckerWdf added this to the 4.34 M1 milestone Sep 24, 2024
@BeckerWdf
Copy link
Contributor Author

@jukzi: Are the log entries in the test execution now gone for this PR?

@jukzi
Copy link
Contributor

jukzi commented Sep 24, 2024

@jukzi: Are the log entries in the test execution now gone for this PR?

i am not sure what you asking.
https://download.eclipse.org/eclipse/downloads/drops4/I20240923-1800/testresults/ep434I-unit-mac64-java17_macosx.cocoa.x86_64_17/org.eclipse.debug.tests.AutomatedSuite.txt still shows thousends.

java.lang.RuntimeException: Some job is still running or waiting to run: 
'AutoRegisterSchemeHandlersJob(19)'/org.eclipse.urischeme.AutoRegisterSchemeHandlersJob:RUNNING

but its only in the i-build not tested for every PR

@BeckerWdf
Copy link
Contributor Author

but its only in the i-build not tested for every PR

I thought it's also visible in PR-builds. So we have to merge this and have a look into the next i-build

@BeckerWdf
Don't run the automatic registration during test execution
1d50b54 
If the IDE is running because we are executing automated tests it
doesn't make sense to run this registration job.

Fixes : eclipse-platform#2245
@BeckerWdf BeckerWdf force-pushed the not_run_link_handler_registration_in_test_execution branch from f9ba59b to 1d50b54 Compare October 4, 2024 12:30
sratz
sratz approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@sratz sratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test failure is unrelated

@BeckerWdf BeckerWdf merged commit 7b0f776 into eclipse-platform:master Oct 4, 2024
15 of 17 checks passed
@BeckerWdf BeckerWdf deleted the not_run_link_handler_registration_in_test_execution branch October 4, 2024 13:42
@BeckerWdf
Copy link
Contributor Author

AutoRegisterSchemeHandlersJob

In the meantime I don't see them any more.
@jukzi: Can you confirm this is fixed?

@jukzi
Copy link
Contributor

jukzi commented Oct 8, 2024

confirmed:
https://download.eclipse.org/eclipse/downloads/drops4/I20241007-1800/testresults/ep434I-unit-mac64-java17_macosx.cocoa.x86_64_17/org.eclipse.debug.tests.AutomatedSuite.txt
does not contain "AutoRegisterSchemeHandlersJob" anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sratz sratz sratz approved these changes

Assignees

@BeckerWdf BeckerWdf

Labels
None yet
Projects
None yet
Milestone
4.34 M1
Development

Successfully merging this pull request may close these issues.
3 participants
@BeckerWdf @jukzi @sratz