Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stacktrace from DataFormatException but add raw value #2521 #2696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove stacktrace from DataFormatException but add raw value #2521 #2696

wants to merge 1 commit into from

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jan 14, 2025

looks less scary
image

#2521

@jukzi jukzi requested a review from opcoach January 14, 2025 16:13
laeubi
laeubi reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to loose any way to find our what is wrong here...

@jukzi
Copy link
Contributor Author

jukzi commented Jan 14, 2025

This seem to loose any way to find our what is wrong here...

there is nothing wrong. if you wanted to debug the thing you still can as the error message is unique:
image

@laeubi
Copy link
Contributor

laeubi commented Jan 14, 2025

there is nothing wrong.

Why do we log a message if nothing is wrong?

In your screenshot it says can't parse value but why? So I would expect some kind of number format exception, wrong values, missing comma, ....

@jukzi
Copy link
Contributor Author

jukzi commented Jan 14, 2025

In your screenshot it says can't parse value but why? So I would expect some kind of number format exception, wrong values, missing comma, ....

??? that was not given before either. now you at least see the bad value in the logging.

@laeubi
Copy link
Contributor

laeubi commented Jan 14, 2025 •
edited
Loading

It would of course help to see the full exception message/trace before.... from the mentioned codepath it could handle different cases and some might contain a useful message.

@jukzi
Copy link
Contributor Author

jukzi commented Jan 14, 2025

There are literally 0 bugs in bugzilla and github about any DataFormatException. so no one ever needed such stacktrace

@laeubi
Copy link
Contributor

laeubi commented Jan 14, 2025

There are literally 0 bugs in bugzilla and github about any DataFormatException. so no one ever needed such stacktrace

Or everyone was able to fix the issue just from the stack-trace before ;-)

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 43m 37s ⏱️ + 7m 50s
 7 733 tests ±0   7 505 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 360 runs  ±0  23 611 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 4fd5554. ± Comparison against base commit 74efba4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi left review comments

@opcoach opcoach Awaiting requested review from opcoach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jukzi @laeubi