-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate monitor-specific scaling before Display instantiation #2704
Activate monitor-specific scaling before Display instantiation #2704
Conversation
7fd118a
to
2d53a65
Compare
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
Test Results 1 817 files - 1 1 817 suites - 1 1h 29m 51s ⏱️ + 2m 22s For more details on these failures, see this check. Results for commit bbdbb0d. ± Comparison against base commit 871538d. ♻️ This comment has been updated with latest results. |
1c67cea
to
6008972
Compare
57778fa
to
abfa8ee
Compare
Monitor-specific scaling needs to be activated before the display that is supposed to run in that mode is created. Currently, the scaling is activated in the Workbench based on an according preference after the Display has already been created. This change moves the evaluation of the experimental preference and the according initialization of monitor-specific scaling to before the Display is created inside the Workbench. In addition, the disclaimer is cleaned up from the statement about Edge, which is now already been enabled by default.
abfa8ee
to
bbdbb0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the change and from it looks solid and sound to me. Moving the initialization before the Display creation is definitely necessary.
Failing test first occurred in this PR, but is completely unrelated to the change. It was documented here: |
Monitor-specific scaling needs to be activated before the display that is supposed to run in that mode is created. Currently, the scaling is activated in the Workbench based on an according preference after the Display has already been created.
This change moves the evaluation of the experimental preference and the according initialization of monitor-specific scaling to before the Display is created inside the Workbench.
In addition, the disclaimer is cleaned up from the statement about Edge, which is now already been enabled by default.