Replace button in find dialog gets enabled with regular expressions #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Replace" button in find dialog did not get enabled when "Regular expressions" checkbox was set.
Test Results 1 818 files ±0 1 818 suites ±0 1h 34m 11s ⏱️ -24s For more details on these failures, see this check. Results for commit 1cddad7. ± Comparison against base commit 6d3c665. |
HeikoKlare
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thank you, @tobias-melcher!
The change looks good to me and the test is a proper regression test for the issue.
The bug seems to have been introduced by:
So @fedejeanne could you please have a second look at this to ensure that the inverted logic was just introduced by accident?
fedejeanne
approved these changes
Jan 23, 2025
|
Thank you @tobias-melcher for the fix and the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Replace" button in find dialog did not get enabled when "Regular expressions" checkbox was set.
This pull request is fixing the issue so that replace functionality is again possible together with regular expressions.
